Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Have fixed the tests @nineinchnick

I've thought about this, and this is a breaking change for anyone using this data type. What's worse, it's silent, meaning the behavior will just change for anyone not pinned to a specific version of this driver. Even if this change is correct, we should only do this in a v2 version.

If you don't mind, I'd keep this open for a while, hoping we can get more feedback from other people. In the meantime, I'd suggest using a workaround, like you can create a struct implementing sql.Scanner in your application and pass it to Scan() instead of trino.Time.

Can we have the default timezone passed with the connection string like we have for custom http client. Something like ->

if tzKey := query.Get("default_tz"); tzKey != "" {
     loc, err := time.LoadLocation(tzKey)
     if err == nil {
          time.Local = loc
     }
}

That way its both configurable and backwards compatible

@cla-bot check

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

The cla-bot has been summoned, and re-checked this pull request!

@silent-lad I like your last suggestion, can we get back to this? You haven't signed the CLA yet.

https://github.com/trinodb/cla/pull/8/files
I have a PR for the CLA. Haven't gotten it approved. @nineinchnick

PRs are not processed in that repository, you need to send the signed CLA via email.

can we get back to this?

I will update the PR with changes today.

you need to send the signed CLA via email.

Is the procedure documented somewhere so I can follow?

Is the procedure documented somewhere so I can follow?

Yes, please read the cla-bot comments.